BIND 10 #1638: NSEC3PARAM rdata should have more tests

[BIND 10 Development]

#1638: NSEC3PARAM rdata should have more tests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120221
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Looks good, two minor comments;

 nsec3param_common.cc:

 If i read parseNSEC3ParamText() correctly, and salt is too long, it is
 still put into the passed vector. Perhaps not much of a problem (since
 this is in essence a private function and we control the vector), but
 technically not exception-safe. Perhaps do the length check on salthex
 instead of the result vector (whitespace is not allowed anyway)? (or,
 alternatively, mention this explicitely in the doxygen)

 nsec3_50.cc:

 trivial inline comment suggestion: change 'It must not be a padded
 base32hex string.' to 'It must be an unpadded base32hex string" (current
 text might be interpreted as 'must not be base32')

-- 
Ticket URL: <http://bind10.isc.org/ticket/1638#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development