BIND 10 #1649: Config show allows listing non-existing sub-item in list

BIND 10 Development do-not-reply at isc.org
Thu Feb 16 08:57:29 UTC 2012


#1649: Config show allows listing non-existing sub-item in list
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120221
                   Priority:  major  |            Resolution:
                  Component:  bind-  |             Sensitive:  0
  ctl                                |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  1.18
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte
 * totalhours:  0 => 1.18


Comment:

 Hello

 Replying to [comment:7 jelte]:
 > the checking function can in theory work with both, but on the full
 identifier it would be pretty useless (at least without the entire
 specification as context). But it is only used on one path element at a
 time (id_part). So this should work with nested lists.

 OK, I see.

 > BTW, It may not work fully with multi-dimensional lists, but I think we
 should be able to live with that for now (given the way bindctl handles
 lists in the first place, not sure if we ever want multi-dimensional ones,
 and even if so, I think that could wait until the refactor, see below, i
 agree it should be very very high on the agenda).

 ACK, I don't think we need multidimensional lists right now.

 > > Speaking about the `identifier_has_list_index`, is there any reason
 why it is directly inside `cc.data` and not in `config.data`, like the
 rest?
 > >
 >
 > to keep it in the same location as the other code that defines and
 handles indices (whether or not the entirety should be moved can be
 discussed, but I did not want to make even more of a mess of it)

 Hmm, is it possible we'll get rid of these functions in the refactor? I
 don't think it is the best place for them, but I don't think we need to
 spend too much time moving them from place to place right now.

 Anyway, I think this can be merged. But I just noticed there's no
 changelog and this bugfix would probably deserve one.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1649#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list