BIND 10 #254: we should revisit RRset::setName()

[BIND 10 Development]

#254: we should revisit RRset::setName()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  assigned
                       Type:         |             Milestone:
  defect                             |            Resolution:
                   Priority:  major  |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  0.0
                   Keywords:         |           Total Hours:
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by shane):

 * owner:  UnAssigned => jinmei
 * subproject:   => DNS
 * severity:   => N/A


Comment:

 This code is not untouched, but seems to still have the same basic issue,
 as far as I understand it.

 The code in data_source.cc now reads:

 {{{#!cc
         if (cname) {
             RRsetPtr rrset = findRRsetFromList(wild, RRType::CNAME());
             if (rrset != NULL) {
                 rrset->setName(task->qname);
                 addToMessage(q, Message::SECTION_ANSWER, rrset);
                 chaseCname(q, task, rrset);
             }
         } else {
             BOOST_FOREACH (RRsetPtr rrset, wild) {
                 rrset->setName(task->qname);
                 addToMessage(q, Message::SECTION_ANSWER, rrset);
             }
 }}}

 Jinmei, can you confirm that this still should be addressed?

 Is this something we need to change the constness of the
 findRRsetFromList() return value? Or perhaps update the documentation of
 that method?

 Has this been discussed on bind10-dev?

-- 
Ticket URL: <http://bind10.isc.org/ticket/254#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development