BIND 10 #254: we should revisit RRset::setName()

[BIND 10 Development]

#254: we should revisit RRset::setName()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  assigned
                       Type:         |             Milestone:  New Tasks
  defect                             |            Resolution:
                   Priority:  major  |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  0.0
                   Keywords:         |           Total Hours:
            Defect Severity:  Low    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jinmei):

 * milestone:   => New Tasks


Comment:

 Replying to [comment:3 shane]:
 > This code is not untouched, but seems to still have the same basic
 issue, as far as I understand it.
 >
 > The code in data_source.cc now reads:
 >
 > {{{#!cc
 >         if (cname) {
 >             RRsetPtr rrset = findRRsetFromList(wild, RRType::CNAME());
 >             if (rrset != NULL) {
 >                 rrset->setName(task->qname);
 >                 addToMessage(q, Message::SECTION_ANSWER, rrset);
 >                 chaseCname(q, task, rrset);
 >             }
 >         } else {
 >             BOOST_FOREACH (RRsetPtr rrset, wild) {
 >                 rrset->setName(task->qname);
 >                 addToMessage(q, Message::SECTION_ANSWER, rrset);
 >             }
 > }}}
 >
 > Jinmei, can you confirm that this still should be addressed?

 It should still be addressed, and, once again, will be resolved when
 we migrate to the new data source implementation/API.  I'd keep this
 ticket so that we won't forget the cleanup in the libdns++ side.

-- 
Ticket URL: <http://bind10.isc.org/ticket/254#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development