BIND 10 #1593: Cleanup of socket creator code
BIND 10 Development
do-not-reply at isc.org
Fri Feb 17 16:00:41 UTC 2012
#1593: Cleanup of socket creator code
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
vorner | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20120221
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 4
Feature Depending on Ticket: | Total Hours: 0
Socket creator |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => jinmei
Comment:
> Also, if we keep using it, I'd explicitly add dependency to libexception
in the Makefile.am
Missed that - done.
> Going back to the branch, I'd prefer avoiding reinterpret_cast somehow.
If you are okay with it and have a stronger preference on one of the
alternatives...
Not really. It was more of a case of pointing out that however much we
are avoiding the keyword "reinterpret_cast", that is exactly what we are
doing. However, I've applied the contents of the patch you attached to
the ticket and the code now uses convertSockAddr().
As this is a refactor, not changing functionality or fixing a bug, I was
not planning on a !ChangeLog entry.
--
Ticket URL: <http://bind10.isc.org/ticket/1593#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list