BIND 10 #1193: New cppcheck adds new recommendations

[BIND 10 Development]

#1193: New cppcheck adds new recommendations
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  vorner                             |                Status:  new
                       Type:         |             Milestone:  Year 3 Task
  defect                             |  Backlog
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jelte):

 This suddenly annoyed me enough to do something about it.

 The missingIncludes error at the end there turned out to be a bug in
 cppcheck itself (fixed somewhere around 1.51 or 1.52, certainly present in
 1.49), so I upgraded to 1.53 and fixed any additional issues encountered.

 Also added a few more suppressions, in some tests we intentionally do
 stupid things that are caught now (like a.compare(a) == 0)

 Anyway, slightly ahead of the sprint, but with the changes in trac1193
 cppcheck (1.53) succeeds again.

 I'll wait a day before I put it up for review :)

 Note: some of the suggestions in the attachment did not appear for me

-- 
Ticket URL: <http://bind10.isc.org/ticket/1193#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development