BIND 10 #1587: auth::Query NSEC3 support: cleanup

[BIND 10 Development]

#1587: auth::Query NSEC3 support: cleanup
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  accepted
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120306
  critical                           |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac1587 is ready for review.

 I summarized how the NSEC3 cases call findNSEC3() and use the results
 in a table, and decided to categorize the cases into two cases,
 corresponding to recursive/non recursive mode of findNSEC3().  I
 introduced separate private methods for these 2 cases and implemented
 consistent validation policy there.

 Of course, this is not the only reasonable way to unify the cases.
 For example, we could probably even consolidate all cases into a
 single super clever method.  But in my subjective impression based on
 the summary table that would be rather complicated.  I hope my result
 is at least reasonably understandable.

 I'm not answering each point noted in the ticket, but I believe I
 covered all major concerns in this branch.

 I've also performed coverage check.  It was actually quite good, and
 at least I didn't find any uncovered code related to NSEC3 changes.
 The coverage report is available here:
 http://bind10.isc.org/~jinmei/cov-1587/cov/bin/auth/query.cc.gcov.html

 Since we are adding a new user-visible feature, I think we should
 provide a summarized changelog entry.  This is the proposal:
 {{{
 384.?   [func]          haikuo, jelte, jinmei, kevin, vorner
         b10-auth now supports NSEC3-signed zones in the in-memory data
         source.
         (Trac #1580-#1585, #1587, and other related changes to the
         in-memory data source)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1587#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development