BIND 10 #1667: dns::masterLoad should accept comment at EOL

[BIND 10 Development]

#1667: dns::masterLoad should accept comment at EOL
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  haikuo
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120306
                   Priority:         |            Resolution:
  critical                           |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  libdns++                           |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by haikuo):

 I reviewed your changes in this ticket,and it works for the RDATA formats
 you mentioned.
 but I have a question about the method you defined(stripComment), why you
 find the last semicolon but not the first one? As I know, the semicolon
 means that the later words after it should be treated as the comments. If
 you find the first semicolon and then erase all the later words, do you
 think it will be better than your method? Of cause no body want to modify
 the zonefile which was signed firstly,but I think our software will be
 robust if we do that.


 For the function "masterLoad" you modified,you deal with the semicolon by
 using an exception, I think it is good for the performance although it
 looks like weird.
 thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/1667#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development