BIND 10 #567: RdataIterator::getCurrent() should throw if invalid.

[BIND 10 Development]

#567: RdataIterator::getCurrent() should throw if invalid.
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  assigned
                       Type:         |             Milestone:
  enhancement                        |            Resolution:
                   Priority:  minor  |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  0.0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by shane):

 * owner:   => vorner
 * status:  new => assigned
 * subproject:   => DNS
 * component:  Unclassified => data source
 * severity:   => N/A


Comment:

 I had a quick look at this ticket, and actually I can't see if
 !RdataIterator is actually used.

 I only see it at one place in the code:

 {{{
 [shane at shane-desktop bind10]$ find . -name "*.h" | xargs grep getCurrent
 ./src/lib/dns/rrset.h:    virtual const rdata::Rdata& getCurrent() const =
 0;
 ./src/lib/dns/rrset.h:    /// call to \c next() or \c getCurrent() is
 undefined.
 ./src/lib/dns/rrset.h:            rrsig_->addRdata(it->getCurrent());
 ./src/lib/testutils/dnsmessage_test.h:
 rdit->getCurrent()).typeCovered() ==
 ./src/lib/testutils/dnsmessage_test.h:
 targetit->getCurrent()).typeCovered());
 }}}

 It seems like it is a pure virtual class:

 {{{#!cpp
 virtual const rdata::Rdata& getCurrent() const = 0;
 }}}

 And is never inherited into a concrete class.

 Is this code dead code? Scheduled for clean-up already? Or what?

-- 
Ticket URL: <http://bind10.isc.org/ticket/567#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development