BIND 10 #1534: socket creator should set IPV6_USE_MIN_MTU for AF_INET6 UDP sockets
BIND 10 Development
do-not-reply at isc.org
Fri Feb 24 16:52:11 UTC 2012
#1534: socket creator should set IPV6_USE_MIN_MTU for AF_INET6 UDP sockets
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
jinmei | Status: reviewing
Type: | Milestone:
defect | Sprint-20120306
Priority: major | Resolution:
Component: Boss | Sensitive: 0
of BIND | Sub-Project: Core
Keywords: | Estimated Difficulty: 2
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: UnAssigned => vorner
Comment:
Not that it could currently be a problem I think, but it seems slightly
better to me to only set IPV6_MTU if IPV6_USE_MIN_MTU actually does not
exist; So I propose to change the code slightly to
{{{
if defined(IPV6_USE_MIN_MTU)
foo
elif defined(IPV6_MTU)
bar
fi
I would also like to request that you add a comment in the unittest file
at closeCall(), warning that you should really reset the close_called
value before you run the code that is supposed to call close :) (i'd
almost suggest one would use a fixture but the hassles of bound methods
are probably not worth working around for the current two tests)
Apart from that, it looks good :)
--
Ticket URL: <http://bind10.isc.org/ticket/1534#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list