BIND 10 #1678: Lettuce test for multiple instances
BIND 10 Development
do-not-reply at isc.org
Sat Feb 25 00:09:26 UTC 2012
#1678: Lettuce test for multiple instances
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
vorner | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20120306
Priority: major | Resolution:
Component: | Sensitive: 0
Unclassified | Sub-Project: Core
Keywords: | Estimated Difficulty: 8
Defect Severity: N/A | Total Hours: 2
Feature Depending on Ticket: |
Multiple interfaces |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
First, it didn't work for me:
{{{
If I remember the pid of process b10-auth
# features/terrain/bind10_control.py:189
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/lettuce/core.py", line 117,
in __call__
ret = self.function(self.step, *args, **kw)
File
"/Users/jinmei/src/isc/git/bind10-1678/tests/lettuce/features/terrain/bind10_control.py",
line 201, in remember_pid
running_processes = parse_bindctl_output_as_data_structure()
File
"/Users/jinmei/src/isc/git/bind10-1678/tests/lettuce/features/terrain/bind10_control.py",
line 186, in parse_bindctl_output_as_data_structure
"parseable data structure: " + str(ve)
AssertionError: Last bindctl output does not appear to be a parseable data
structure: Extra data: line 29 column 1 - line 29 column 9 (char 302 -
310)
}}}
In my environment there seems to be some other extra garbage in the
output. The attached patch worked for me.
Second, I made a usual editorial cleanup.
Third, remember_pid() and check_pid() look quite similar and could use
a shared helper function to avoid code duplicate.
Other than that it looks okay.
(The commented-out test failed for me, but I agree it's better than
nothing.)
--
Ticket URL: <http://bind10.isc.org/ticket/1678#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list