BIND 10 #1599: introduce "asiodns::UDPSyncServer"

[BIND 10 Development]

#1599: introduce "asiodns::UDPSyncServer"
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  kevin_tes
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120306
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  7
Feature Depending on Ticket:  auth   |           Total Hours:  0
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by kevin_tes):

 Hi,sorry for the late review.

 The unittest codes and the class look good to me.
 A litter things I take here.
 {{{
     if (ec) {
         using namespace asio::error;
         if (ec.value() != would_block && ec.value() != try_again &&
             ec.value() != interrupted) {
             return;
         }
         // Some kind of interrupt, spurious wakeup, or like that. Just try
 reading
         // again.
         if (0 == length) {
             scheduleRead();
             return;
         }
     }
 }}}
 Instead of this one,may be better for performance consider.
 {{{
     if (ec) {
         using namespace asio::error;
         if (ec.value() != would_block && ec.value() != try_again &&
             ec.value() != interrupted) {
             return;
         }
     }
     // Some kind of interrupt, spurious wakeup, or like that. Just try
 reading
     // again.
     if (ec || length == 0) {
         scheduleRead();
         return;
     }

 }}}
 May be the comments for this method should be changed in order to explain
 why it throws here.
 {{{
     /// \brief Clones the object
     ///
     /// \return a newly allocated copy of this object
     virtual DNSServer* clone() {
         isc_throw(Unexpected, "SyncUDPServer can't be cloned.");
     }
 }}}

 As I am not so familiar with the code associated, if the review seems not
 so efficiently, please ask other person to recheck it.

 All the other looks good to me,that means if you agree, this ticket can be
 merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1599#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development