BIND 10 #1678: Lettuce test for multiple instances

BIND 10 Development do-not-reply at isc.org
Mon Feb 27 19:24:58 UTC 2012


#1678: Lettuce test for multiple instances
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120306
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  8
            Defect Severity:  N/A    |           Total Hours:  2
Feature Depending on Ticket:         |
  Multiple interfaces                |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:8 jelte]:

 We've discussed and ddressed the following points on jabber, so
 I'm okay with the branch now.  I'll send the note for the record anyway.

 > may not be entirely related, but those asio changes do indeed seem to
 fix all the issues i have seen.
 >
 > For the completeness of this branch, I've merged them in here (also
 merged master btw)
 >
 > And to address your comments:
 >
 > refactored the _pid functions with a new helper function
 get_process_pid()

 find_process_pid() seems to have incorrect return:

 {{{#!python
     return None
     assert False, "Process named " + process_name +\
                   " not found in output of Boss show_processes";
 }}}

 > Applied your patch, but modified it into two separate replacements, one
 for the Exit statement (i'm hoping we'll remove it at some point), and the
 remove-garbage is now also a string-replace, which should work with all
 forms of JSON output, not just arrays. But please verify whether i did not
 reintroduce your problem :)

 As we discussed on jabber, the revised filter doesn't work for me.
 If a reverted that part to my proposed one:
 {{{#!python
     output = re.sub("(.*)([^]]*$)", r"\1", world.last_bindctl_stdout)
 }}}
 the test succeeded with the system contained in the branch (recent
 master + ASIO fixes).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1678#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list