BIND 10 #1602: Introduce dns::LabelSequence class

BIND 10 Development do-not-reply at isc.org
Tue Feb 28 23:13:38 UTC 2012


#1602: Introduce dns::LabelSequence class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120306
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  7
Feature Depending on Ticket:  auth   |           Total Hours:  0
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 arg, apparently trac was acting up again and my ticket change wasn't
 submitted.

 Ready for review, some notes:
 - Name object got a new method at_p (needed for raw access in getData)
 - getData takes a pointer to a size_t where the 'result' length is stored
 (we could make a separate method getDataLen() but forcing it this way
 makes the chance of caller errors much less IMO)
 - did not make a toLabelSequence() method, but just a LabelSequence(Name&)
 constructor
 - If we find later that we are creating a lot of LabelSequence instances
 from one Name, we can probably easily add a reset() method to this new
 class

-- 
Ticket URL: <http://bind10.isc.org/ticket/1602#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list