BIND 10 #1722: RR reader EOL whitespace
BIND 10 Development
do-not-reply at isc.org
Wed Feb 29 12:55:17 UTC 2012
#1722: RR reader EOL whitespace
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: jelte
Type: | Status: reviewing
defect | Milestone:
Priority: major | Sprint-20120306
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 1
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jelte
Comment:
Hello
It looks OK, except that all the added tests has this comment at the
beginning, which is not true at any of them. I guess it's a copy-paste of
a different test:
{{{#!c++
TEST_F(MasterLoadTest, loadRRWithEOLWhitespaceTab) {
// Similar to the previous one, but there's no space before comments.
// It should still work.
}}}
After fixing them, I think this can be merged (but maybe it could use
little bit of history rewriting to avoid the inclusion and removal of the
wrong commit before merge ‒ I could do that, if it is a problem).
--
Ticket URL: <http://bind10.isc.org/ticket/1722#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list