BIND 10 #805: Client side code to request new sockets (C++)

[BIND 10 Development]

#805: Client side code to request new sockets (C++)
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120110
                   Priority:         |            Resolution:
  blocker                            |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  Unclassified                       |  Estimated Difficulty:  5
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
  Socket creator                     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:22 jinmei]:
 > It seems to me that 01d2bc6 fixed the leak.  I suspect, from that you
 > (reportedly) couldn't install it, that you tested it "from source"
 > using run_bind10.sh without even selectively installing the socket
 > creator program.
 >
 > If my guess is correct, you are hit by another, unrelated bug that the
 > bind10.special_component module unconditionally invokes the installed
 > version of socket creator.  If that is the case please try the
 > attached patch.

 Thanks, yes, you're right. I included the patch. I'll have to solve the
 installation problem of mine sometime.

 > As for how to test SO_REUSEADDR, if it's okay to actually get the
 > socket the creator code we can test it using getsockopt.

 I added the test. I also added another option ‒ the ipv6 only for INET6
 sockets the same way, to keep compatibility. But I think we might want to
 rethink using this one, as the only „problem“ it solves is different
 default list of addresses for different systems.

 > - at least per API even close(2) could fail.  I believe we should
 >   catch that case and kill the socket creator should that happen.
 > - same for send_fd()

 I added the termination of the application. But I'm not sure if we really
 do want to do that, if it isn't better to leak the socket than to bring
 the whole bind10 down. Anyway, close shouldn't fail for the sockets in
 socket creator, so it probably doesn't matter.

 > - sockcreator.cc breaks many style guidelines.

 Well, the code there is 1.5 years old, maybe some of the guidelines are
 newer than that. If we want to clean it up, should it go to another
 ticket?

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/805#comment:23>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development