BIND 10 #1568: Change throw to assert to gain performance

[BIND 10 Development]

#1568: Change throw to assert to gain performance
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120124
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  performance                        |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I suggest we hold off merging (or perhaps reviewing) this change until
 we see the effect of MessageRenderer refactoring (part of changes
 now available in jinmei-labelseq).  In my experiment it could increase
 the qps performance more than 50%, and doesn't rely on
 OutputBuffer::operator[] in the first place, so probably making this
 change moot in terms of performance improvement.

 That refactoring work itself is not big, so I believe we can
 reasonably complete that task by the end of y3.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1568#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development