BIND 10 #1399: auth per opcode statistics

[BIND 10 Development]

#1399: auth per opcode statistics
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20120124
                  Component:         |            Resolution:
  statistics                         |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  Auth   |           Total Hours:  0
  statistics                         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:10 jelte]:
 > I agree with your approach to put this in now.
 >
 > I hope your ideas for a refactor include making it a map and not caring
 which specific values opcodes can have :) (and that perhaps for people
 that don't care about stats and want to squeeze out every last cycle to
 disable counters completely)

 Hmm, I'm not sure about what these means...but surely we don't want to
 enumerate all possible opcodes in the spec file, so a future version
 of the framework should at least allow the spec files (or whatever the
 statistics definition is) to avoid that.

 > one minor comment; the spec file misses a number of spaces (in the
 descriptions of the reserved values, from 8 on)

 Ah, good catch, thanks.  Fixed in the branch.

 > given the approach, code itself looks ok

 Okay, thanks for the review, I'll merge it and close the ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1399#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development