BIND 10 #1431: NSEC3: closest provable encloser proof

[BIND 10 Development]

#1431: NSEC3: closest provable encloser proof
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20120124
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:21 vorner]:

 > > > Indentation:
 > > > {{{
 > > > +        /// TBD
 > > > +       virtual FindNSEC3Result
 > > > +        findNSEC3(const isc::dns::Name& name, bool recursive,
 > > > +                  const isc::dns::ConstRRsetPtr known_encloser);
 > > > +
 > > > }}}
 >
 > Actually, one indentation problem was left (there were tabs for some
 reason), and I fixed it.

 Oops, thanks.

 > Replying to [comment:19 jinmei]:

 > > I've updated the branch toward this direction, but not completely
 > > deprecated WILDCARD_xxx as it would require rather big changes to the
 > > existing database data source implementation.  For now, I introduced a
 > > quick hack wrapper in the auth Query code to convert the old format to
 > > the new one.
 > >
 > > If this approach is okay I'll create a separate ticket for the
 > > subsequent refactoring.
 >
 > The wrapper looks kludge to me, but provided the ticket is handled soon
 enough (possibly in the next sprint), I think it is OK. The ticket should
 be relatively small, the only place that used WILDCARD_xxx is the database
 datasource and the compiler should be able to find all the occurrences if
 the definitions are removed.

 I know it's a kludge, and while the cleanup fix is essentially
 straightforward, the diff is actually not small (right now git diff on
 my trac1611 branch is over 1000 lines, containing 78 chunks.  This
 work is mostly done except for documentation update, so I'm quite sure
 we can clean them up in the next sprint.

 > The code itself looks good enough to merge, so please do. We can discuss
 the inclusion of hints or whatever in the result later and outside of this
 ticket, possibly on the next non-planning call? Or the mailing list?

 Both mailing list and biweekly call sound good to me.

 For the moment I'll merge the current branch and close this ticket.
 Thanks.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1431#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development