BIND 10 #1454: Pass UPDATE packets from b10-auth to DDNS module
BIND 10 Development
do-not-reply at isc.org
Tue Jan 24 17:31:43 UTC 2012
#1454: Pass UPDATE packets from b10-auth to DDNS module
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: jinmei
Type: task | Status: reviewing
Priority: minor | Milestone:
Component: DDNS | Sprint-20120207
Keywords: | Resolution:
Defect Severity: N/A | Sensitive: 0
Feature Depending on Ticket: DDNS | Sub-Project: DNS
Add Hours to Ticket: 0 | Estimated Difficulty: 3
Internal?: 0 | Total Hours: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:17 vorner]:
>
> I updated the comment in the loop and added few TODO ones to some of the
handlers.
>
> I also started handling the exceptions on accept.
>
> I believe the functions themself have better knowledge of what
exceptions would be fatal and what not. A socket error from the accept is
recoverable, we just didn't get the exception, but socket error from the
check_command might not, for example (if it ever got out, I guess it
should not, but if there was a bug…).
>
> Would this work?
Looks okay, with one minor nit:
{{{
(probably coming from b10-auth). We continue serving on whanever other
}}}
s/whanever/whatever/ (or whichever?)
With fixing this please feel free to merge.
--
Ticket URL: <http://bind10.isc.org/ticket/1454#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list