BIND 10 #1575: move data_source.cc:Nsec3Param to libdns++

[BIND 10 Development]

#1575: move data_source.cc:Nsec3Param to libdns++
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120207
  critical                           |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jinmei):

 * owner:  jinmei => UnAssigned
 * status:  accepted => reviewing


Comment:

 trac1575 is ready for review.

 On thinking about details, I decided to keep it a class.  The
 rationale was documented in the doxygen comment.

 I found one bug in the original implementation: it didn't handle
 case-sensitiveness correctly (produced different hash for "com" and
 "COM").  The new version fixed it with a test case for it.

 I also noted another, slightly related bug in the NSEC3PARAM rdata
 implementation: its "from text" constructor didn't handle an empty
 salt.  It could go to a separate ticket, but I wanted to test the case
 for this branch, so I fixed it here, too.

 Finally, I provided python binding (0879661).  It may be against the
 YAGNI principle, but at the same time I wanted to keep the C++ and
 Python libraries as compatible as possible.  The binding code should
 be straightforward (and not that big even if it was written from
 scratch), but if the branch looks too big due to it, I'm okay with
 deferring it to a separate ticket.

 I think it's worth a changelog entry.  This is the proposed one:

 {{{
 369.?   [func]          jinmei
         libdns++: a new class NSEC3Hash was introduced as a utility ofn
         calculating NSEC3 hashes for various purposes.  Python binding was
         provided, too.  Also fixed a small bug in the NSEC3PARAM RDATA
         implementation that empty salt in text representation was
         rejected.
         (Trac #1575, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1575#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development