BIND 10 #1575: move data_source.cc:Nsec3Param to libdns++

BIND 10 Development do-not-reply at isc.org
Fri Jan 27 22:32:36 UTC 2012


#1575: move data_source.cc:Nsec3Param to libdns++
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120207
  critical                           |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  NSEC3  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:9 vorner]:

 {{{#!c++
 class NSEC3HashBase {
 public:
     static NSEC3HashBase* create(const rdata::generic::NSEC3PARAM& param);
     virtual std::string calculate(const Name& name) const = 0;
 };
 }}}
 > > (maybe we could name the base class `NSEC3Hash` and hide the concrete
 > > one in the implementation).
 >
 > Yes, something like this, and I'd prefer hiding the concrete one.

 Updated.

 > > As a general issue, it may help if we mark such comments in the
 > > template like this:
 > > {{{#!c++
 > > // THIS BLOCK OF COMMENT MUST BE REMOVED FROM THE PUBLISHED VERSION
 > > // This is a template of typical code logic of python class
 initialization
 > > // with C++ backend.  You'll need to adjust it according to details of
 the
 > > // actual C++ class.
 > > }}}
 >
 > Hopefully it'll help. Maybe it could even be not a comment, so the
 compiler could fail in case someone forgets to remove it?

 I tried to add something like that.  It's basically out of scope of
 this ticket, but probably small enough to be a separate task, so I
 committed the change to this branch, too.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1575#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list