BIND 10 #1543: the socket requestor should abort itself on unexpected errors

[BIND 10 Development]

#1543: the socket requestor should abort itself on unexpected errors
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120207
                   Priority:         |            Resolution:
  blocker                            |             Sensitive:  0
                  Component:  Boss   |           Sub-Project:  DNS
  of BIND                            |  Estimated Difficulty:  3
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
  Socket creator                     |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 The code itself looks good, just a few nits, which are not really specific
 to this changeset, but bothered me anyway :)

 - I see the added try-catch block in portconfig.cc uses a slightly
 different braces style than most of the rest of the code; a newline before
 the catch. This is consistent with some of the existing catches in this
 file, and in fact is used in more places, but most of the time we put the
 catch on the same line as the closing brace. This is not really specified
 in our style guide, but I personally prefer the same-line approach, though
 of course opinions may differ :)

 - I also am not really fond of the use of 'we' in the error message
 descriptions; e.g. change

 {{{
 The situation is the same as in the SRVCOMM_EXCEPTION_ALLOC case, but we
 don't
 know further details about the error, because it was signaled by throwing
 something not being an exception. This is definitely a bug.
 }}}
 to (for instance)
 {{{
 The situation is the same as in the SRVCOMM_EXCEPTION_ALLOC case, but
 further
 details about the error are unknown, because it was signaled by throwing
 something that was not an exception. This is definitely a bug.
 }}}

 Again, not something unique to this changeset (we do it in more messages),
 but I'd prefer we don't add more :)

 Same for the other added message.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1543#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development