BIND 10 #2077: add NO_EXPECT_DEATH

BIND 10 Development do-not-reply at isc.org
Mon Jul 2 12:27:24 UTC 2012


#2077: add NO_EXPECT_DEATH
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  fdupont                            |                Status:  new
                       Type:         |             Milestone:  New Tasks
  enhancement                        |            Resolution:
                   Priority:         |             Sensitive:  0
  medium                             |           Sub-Project:  Core
                  Component:         |  Estimated Difficulty:  0
  Unclassified                       |           Total Hours:  0
                   Keywords:         |
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by fdupont):

 The idea of EXPECT_DEATH is to handle unittests where a runtime check
 raises a fatal (so "death") error. The EXPECT_DEATH flag can be in
 includes (e.g., in the Google test local setup) or in a compilation flag
 (i.e., part of CXXFLAGS).
 My issue is the two ways are not compatible, i.e., when the flag is
 defined in gtest includes there is no way to disable it at C++ compiler
 invocation. Usually it doesn't matter because the system is compiled once
 with the proper environment but it is not the case of Visual Studio which
 in standard compiles two versions named "Release" and "Debug". Of course
 it is possible to get the corresponding flags (they are documented) but I
 prefer to not dig into the Google test stuff. And the Microsoft runtime
 check system is GREAT: it already caught a lot of bugs, i.e., it is very
 different from the g++ STL... so I'd like to keep it!
 My proposal is to use two flags so it is easily possible to disable the
 EXPECT_DEATH tests for instance in defining in "Release" configuration
 only the NO_EXPECT_DEATH flag. BTW it works well and the change is trivial
 (i.e., as soon as you'll catch the idea you should adopt it :-).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2077#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list