BIND 10 #2115: a shared_ptr is a pointer

[BIND 10 Development]

#2115: a shared_ptr is a pointer
-------------------------------------+-------------------------------------
            Reporter:  fdupont       |                        Owner:
                Type:  enhancement   |                       Status:  new
            Priority:  low           |                    Milestone:  New
           Component:  Unclassified  |  Tasks
           Sensitive:  0             |                     Keywords:
         Sub-Project:  Core          |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 If a shared_ptr is really a pointer then MSVC is right when it raises an
 error on this contruct
 (from src/lib/datasrc/tests/zonetable_unittest.cc):
 {{{zone.find(Name("www.example.com"), RRType::A()).code}}}
 the result of zone.find() is a shared_ptr and MSVC claims a shared_ptr has
 no code member...
 The fix is to replace by:
 {{{zone.find(Name("www.example.com"), RRType::A())->code}}}
 but my question is whether MSVC is a bit picky or is plain right and the
 code must be fixed?
 (I put the proposed change in the attachment so with other words should I
 remove the #ifdef?)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2115>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development