BIND 10 #2044: In-Memory cache in ClientList

[BIND 10 Development]

#2044: In-Memory cache in ClientList
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120717
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  7
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  Use    |
  new datasources                    |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 No comments on the code, it looks good and can be merged, some general
 questions though (feel free to point me to -dev :P);

 I wonder if we should check whether a zone is present in multiple
 datasources; that might result in some unexpected behaviour (not really
 specific here, but the way they are added to the cache reminded me of it).

 This seems a lot like running memory datasource that loads from sqlite3
 (except this will hopefully be load-on-demand completely in the future) :)
 Will this replace that or will we have both? (i.e. the to be implemented
 cache_all option).

 I don't recall if this would be part of the zoneloaderv2 work., but did we
 intend to change the way zones are loaded in the API? The intermediate
 zonefinder creation seems unnecessary, and things would look simpler if we
 could just call load() directly on InMemoryClient; or perhaps even make it
 a public call of DataSourceClient (in that case we can remove the
 InMemoryClient class from the code here completely, and initialize a base
 datasourceclient as an inmemory one). Though of course the latter would
 need some consideration as to what to do for different types of
 datasource.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2044#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development