BIND 10 #1883: define tp_hash for some basic isc.dns classes

BIND 10 Development do-not-reply at isc.org
Wed Jul 4 14:52:37 UTC 2012


#1883: define tp_hash for some basic isc.dns classes
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  high   |  Sprint-20120717
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 I had a comment about Py_hash_t but I see we already have #2026 for that
 (do we care about the implicit cast there, btw?) :)

 I have one tiny suggestion for the unit tests; add
 {{{
         self.assertEqual(hash(RRType.AAAA()), hash(RRType("Type28")))
 }}}
 as well (or a similar one).

 Other than that, this looks OK and can be merged.

-- 
Ticket URL: <https://bind10.isc.org/ticket/1883#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list