BIND 10 #2086: allow construct LabelSequence from "raw data"

BIND 10 Development do-not-reply at isc.org
Mon Jul 9 08:26:27 UTC 2012


#2086: allow construct LabelSequence from "raw data"
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120717
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Ready for review.

 Didn't know exactly how this is intended to be used, but depending on
 that, we could consider not using the real raw data for the offsets, but a
 reference to the vector as constructed in Name; would shave off one more
 member (currently it also needs the size of that data).

 I moved the comparison code from Name to LabelSequence, similar to how
 toText already worked (i.e. Name::compare() now constructs labelsequences
 instead of doing comparison itself). It does have a few changes (an extra
 isAbsolute() check, and removed a few checks that are now no longer
 necessary).

-- 
Ticket URL: <http://bind10.isc.org/ticket/2086#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list