BIND 10 #2086: allow construct LabelSequence from "raw data"

[BIND 10 Development]

#2086: allow construct LabelSequence from "raw data"
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120717
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Hi Jelte

 * In `LabelSequence::getData(size_t *len)`, this would need brackets
 around the `return` in our coding style:
 {{{
 +    return &(data_[offsets_[first_label_]]);
 }}}

 * This is the behavior we want, right (there's no constructor that makes a
 copy of the data)?
 {{{
 +    /// \note The associated data MUST remain in scope during the
 lifetime
 +    /// of this LabelSequence, since only the pointers are copied.
 }}}

 * For `COMMONANCESTOR` tests, please check the returned # of common labels
 and order too.

 The `compare()` moved from `Name` looks ok, modifications to `toText()`,
 etc. are fine and the constructors and tests look fine too. `make check`
 passes, so you have a successful review. Please go ahead and merge after
 you look at the points above. :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2086#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development