BIND 10 #2123: New suggestions by cppcheck 1.55

[BIND 10 Development]

#2123: New suggestions by cppcheck 1.55
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  defect        |                       Status:  new
            Priority:  medium        |                    Milestone:  Next-
           Component:  Unclassified  |  Sprint-Proposed
           Sensitive:  0             |                     Keywords:
         Sub-Project:  Core          |              Defect Severity:  N/A
Estimated Difficulty:  0             |  Feature Depending on Ticket:
         Total Hours:  0             |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
 Again, my OS got a new version of the `cppcheck` tool and it discovered
 some new issues, mostly style.

 As they would be mostly trivial to solve, I'm proposing this to next-
 sprint-proposed.

 Here they are:
 {{{
 src/lib/config/module_spec.cc:479: check_fail: The scope of the variable
 'found' can be reduced (style,variableScope)
 src/lib/log/tests/logger_name_unittest.cc:35: check_fail: Variable 'name_'
 is assigned in constructor body. Consider to perform initalization in
 initialization list. (performance,useInitializationList)
 src/lib/server_common/tests/socket_requestor_test.cc:453: check_fail:
 Function parameter 'data' should be passed by reference.
 (performance,passedByValue)
 src/lib/util/filename.cc:37: check_fail: The scope of the variable
 'dir_present' can be reduced (style,variableScope)
 src/lib/util/strutil.cc:42: check_fail: The scope of the variable 'blanks'
 can be reduced (style,variableScope)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2123>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development