BIND 10 #2087: add LabelSequence::getOffsetData() method
BIND 10 Development
do-not-reply at isc.org
Fri Jul 13 14:45:31 UTC 2012
#2087: add LabelSequence::getOffsetData() method
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120717
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
scalable inmemory |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => muks
Comment:
There is one thing that I noticed (not necessarily just because of this
ticket, but the combination with #2086 does make it visible;
if you pull out data and offsets, you cannot use them to create a new
labelsequence, or at least, not one with the same properties as the one
you got the data from; the isAbsolute() property is 'reset' to true in the
new object (because of the way that property is stored/checked). This
could potentially also change comparison behaviour
This may actually be a feature, or a bug, depending on the intended use (I
have not decided which I think it is yet). And it may be useful, or might
not matter in practice.
It is fixable, but would require more info to go to the raw constructor i
think. And if we're only going to need this for the rendering than we may
actually want this property.
Anyway, I think the code looks OK, and assuming the above is not a
problem, I think this can be merged.
--
Ticket URL: <http://bind10.isc.org/ticket/2087#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list