BIND 10 #2094: Define and implement RDATA field specs

[BIND 10 Development]

#2094: Define and implement RDATA field specs
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120731
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  6
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 I pushed two small fixes. One to make it compile for me, another to remove
 an unnecessary whitespace.

 Further, I'd like to point to these:

 The new makefiles contain this. What is the purpose? The In-Memory will
 have nothing in common wit sqlite3, I hope:
 {{{
 AM_CPPFLAGS += $(SQLITE_CFLAGS)
 }}}

 In this code, maybe we should at least assert that the `olen` fits into
 `uint8_t`, otherwise we'll silently truncate.

 Why use `FAIL()` and condition, if there could be `ASSERT_EQ()`? The
 `ASSERT_*` macros do allow `<<` too. Also, is it better to have hard-
 failure than `EXPECT_*`?
 {{{#!c++
 if (expected_len != actual_len) {
     FAIL() << "Wire data mismatch in length:\n"
            << "  Actual: " << actual_len << "\n"
            << "Expected: " << expected_len << "\n";
 }
 }}}

 Is there a reason to start using at-signs instead of backslashes for
 doxygen? It breaks consistency.
 {{{#!c++
 /// @file wiredata.h
 /// @short Utilities for tests with wire data.
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2094#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development