BIND 10 #2092: RBNode parent pointer updates

[BIND 10 Development]

#2092: RBNode parent pointer updates
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120731
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 The code looks mostly OK. Just:
  * The test (`getUpperNode`), when it expects NULL, it should check it
 actually got one. It seems to me there's no checking if the expected is
 NULL.
  * While merging, a care should be taken, as the internal data are now
 using offset_ptr instead of bare pointers. Some of your new code will need
 to be adjusted.
  * As noted in #2090, it expected this ticket will stop using the sentinel
 nodes and replace them by real NULLs. As it doesn't seem to have happened,
 either of these need to be done:
    - Replace the sentinels with NULLs
    - Replace the NULL node in the tree with an offset_ptr, so it can be
 shared too.

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/2092#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development