BIND 10 #2148: extendable LabelSequence

BIND 10 Development do-not-reply at isc.org
Wed Jul 25 16:56:23 UTC 2012


#2148: extendable LabelSequence
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120731
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Ready for review.

 the branch was based on 2091a, since that one changed some fundamental
 things in how labelsequences work

 a few notes:
 - extend() does a few basic tests, like whether the pointers match, and
 whether the data would not overflow), but it does not verify the data
 integrity; if the caller insists on mucking with the buffer, he's on his
 own :)
 - while we could simply error if you call extend() on a name that is
 absolute, i chose not to, and to strip the root label from the current
 name, before extending it.
 - I added helper functions check_equal and check_compare, which may also
 be used in existing tests, but i did not refactor those yet, if this looks
 ok to do, let me know in the review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2148#comment:2>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list