BIND 10 #2106: allow RBTree::find to take LabelSequence

[BIND 10 Development]

#2106: allow RBTree::find to take LabelSequence
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120731
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jinmei


Comment:

 Hi Jinmei

 Replying to [comment:5 jinmei]:
 > Basically looks okay, but I have some minor points.
 >
 > - doxygen docs for the `Name` and `LabelSequence` versions are mostly
 >   duplicate.  I'd unify them to minimize redundant text.  Or, perhaps
 >   we might even obsolete the name version if it's really only used from
 >   `InMemoryZoneFinder`.

 The Name method has been removed and the memory datasrc now uses the
 LabelSequence variant.

 > - Likewise, can we share the code for callbackXXX tests?  They'd
 >   better be unified both for minimizing dups and for making both cases
 >   more complete.

 Done. :)

 > - In the find() implementation, maybe we rename target_labels to
 >   something like target_labels_orig and keep the original
 >   target_labels as it was?  Especially because due to renaming it
 >   to _copy there's one 'too long' line:
 > {{{#!cpp
 >         node_path.last_comparison_ =
 target_labels_copy.compare(node->getLabels());
 > }}}

 Done. :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2106#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development