BIND 10 #2124: RFC 6594 for SSHFP

[BIND 10 Development]

#2124: RFC 6594 for SSHFP
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  vorner                             |                Status:  closed
                       Type:         |             Milestone:
  defect                             |  Sprint-20120731
                   Priority:         |            Resolution:  fixed
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  libdns++                           |  Estimated Difficulty:  2
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to master in commit 49e6644811a7ad09e1326f20dd73ab43116dfd21:

 {{{
 * 2c86895 [2124] Don't catch InvalidBufferPosition when parsing wiredata
 * 9b88b6b [2124] Rewrite code to avoid duplication
 * 5a7c29f [2124] some editorial fixes to test data comments
 * d2355e5 [2124] prefer empty() over size() > 0 (see the previous commit)
 * a09cb3f [2124] some suggested changes: - use !empty() instead of size()
 > 0
 * 4017593 [2124] Rename SSHFP getter methods
 * d71f7e9 [2124] Add another toWire() test
 * 73080d9 [2124] Don't add trailing space in toText() if fingerprint is
 empty
 * 595b447 [2124] Don't access fingerprint_ data when size is 0
 * 26401e4 [2124] don't keep a reference to a temporary object.
 * 31477bf [2124] Test toWire() with empty fingerprint data
 * 3b82a4f [2124] Handle empty SSHFP fingerprints
 * 16cd39d [2124] Add wiredata tests where the record is shorter than rdata
 len indicates
 * d75a744 [2124] Add another wiredata test with short fingerprint data
 * 6efceee [2124] Remove default values from wiredata spec files
 * 67872ac [2124] Allow algorithm=0 and fingerprint-type=0
 * 5e7af00 [2124] Add some more wire data tests
 * 25e3471 [2124] Add more tests (check >255)
 * 63c345f [2124] Catch isc::BadValue and throw InvalidRdataText instead
 * 2d714ad [2124] Shorten rdata
 * d0d70f2 [2124] Check that algorithm and fingerprint are in the range
 [1,255]
 * 045ede2 [2124] Indent code according to our coding style
 * d448a7e [2124] trivial style fixes: folded long lines; brace position
 * 50d012e [2124] Relax algorithm and fingerprint type checks for SSHFP
 }}}

 Resolving as fixed. Thank you for the reviews Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2124#comment:27>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development