BIND 10 #1958: Implement perfdhcp statistics component

BIND 10 Development do-not-reply at isc.org
Mon Jul 30 20:06:15 UTC 2012


#1958: Implement perfdhcp statistics component
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  Sprint-
  enhancement                        |  DHCP-20120730
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  perfdhcp                           |  Estimated Difficulty:  16
                   Keywords:         |           Total Hours:  65
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  9      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  8 => 9
 * owner:  marcin => stephen
 * totalhours:  56 => 65


Comment:

 Q: PktList is perhaps better named PktCollection (as the container is not
 a list).
 A: The multi_index_container can be perceived as a list and elements are
 accessed in the same way as we access std::list. It also allows to insert
 and erase elements from the middle of it. What's added is the second (non-
 sequencial) index that allows speedup search of the element by its
 transaction id. Otherwise it acts the same as list so I would keep it as
 it is.

 Q: passDOPacketsWithDelay(): do we need similar functions for the REQUEST-
 ACK, SOLICIT-ADVERTISE, REQUEST-RESPONSE exchanges?
 A: I don't think we do. From the stats manager's perspective the different
 exchange is just a different enum. In this case, having DISCOVER-OFFER is
 sufficient to test its functionality. There is no value added to
 generalise this function at this point. Should this need ever arise, we
 can change it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1958#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list