BIND 10 #2093: implement RBNode Node::getAbsoluteLabelSequence

[BIND 10 Development]

#2093: implement RBNode Node::getAbsoluteLabelSequence
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120731
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Replying to [comment:10 jinmei]:
 > It basically looks okay.  I have a few minor points/suggestions.
 >
 > '''rbtree.h'''
 >
 > - This pharase ends with a comma.  Did you mean a period, or did you
 mean some other phrase after that?
 > {{{#!cpp
 >     /// \param buf A data buffer where the label sequence will be built.
 >     ///            The data in this buffer will be overwritten by this
 call,
 > }}}
 >

 ack, had originally put the \note text there before i moved it. changed to
 period.

 > '''tests'''
 > - I'd test some boundary cases, including: when the node is already
 >   absolute (so there's no need to call to getUpperNode()), and for a
 >   very large labels (see, e.g, the chainLevel test).

 added. I've included the ones for very large labels into the chainLevel
 test itself, so as not to have to repeat the filler logic; it just checks
 every node it adds.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2093#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development