BIND 10 #1912: handle type DS query in database-based data sources correctly

[BIND 10 Development]

#1912: handle type DS query in database-based data sources correctly
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120612
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  6
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:4 vorner]:
 > Hello
 >
 > The code looks clean, but I'm not sure it is doing exactly what is
 needed. It surely does return the DS record that is sitting on the
 delegation point. But what if the query is for a name below the delegation
 point? That one is not authoritative any more and should be delegated. Or,
 I think so, I didn't read the specs regarding this, it just seems logical.

 You're right, and our current implementation ensures that because the
 pure delegation case is handled in findDelegationPoint() before
 findOnNameResult(), and the former doesn't treat type DS query as a
 special case.

 I was aware of this possible confusion, but thought it should be
 pretty clear from the implementation and didn't bother to add an
 explicit test.  But now that it's asked explicitly, I've added a test
 case for it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1912#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development