BIND 10 #1704: log output mixed

[BIND 10 Development]

#1704: log output mixed
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  muks
                       Type:         |                Status:  closed
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120612
  medium                             |            Resolution:  fixed
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  15
            Defect Severity:  N/A    |           Total Hours:  12.25
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to master:
 {{{
 * f71a0c6 [1704] constify
 * 7987b09 [1704] Use the is_locked_ flag to call unlock() just once
 * 1c0e6f8 [1704] Fix comment describing the test in logger_lock_test.cc
 * 52edf76 [1704] Remove empty strings used when concatenating to
 TEST_DATA_TOPBUILDDIR
 * cc84b0a [1704] Change search style for includes in the
 interprocess_sync_* headers
 * f68857b [1704] Don't update the environment inside
 check_environment_unchanged()
 * 0785152 [1704] Clarify why the null logger is used in logger_example
 * 6306fee [1704] Clarify why a null sync object is used in
 LoggerManager::readLocalMessageFile()
 * 8d55fd2 [1704] Clarify why we update the environment in
 check_environment_unchanged()
 * a0bf4ce [1704] Use CLEANFILES instead of clean-local
 * 0887605 [1704] style matters: fold long lines, explicit virtual for
 inherited methods.
 * 56c895c [1704] Cleanup logger_lockfile during make clean
 * 60c3dce [1704] Delete test lockfiles when done
 * d6859a6 [1704] Change env variable used in tests for lockfiles
 * 162e151 [1704] Change task name of object
 * 1f12f3c [1704] Add some tests for InterprocessSyncNull class too
 * 3e8b461 [1704] Use 'logger' as the task name for all interprocess sync
 objects inside log/
 * 949d3d2 [1704] Check that logger acquires and releases locks correctly
 when logging messages
 * e04531f [1704] Add note about exception thrown
 * 3098730 [1704] Set B10_LOCKFILE_DIR_FROM_BUILD for various tests
 * 6b3132f [1704] Use a null InterprocessSync object for some tests
 * 865669e [1704] Update documentation
 * 58c0a8e [1704] Set and use B10_LOCKFILE_DIR_FROM_BUILD in tests
 * 8c38fe1 [1704] Remove log_test_messages.{cc,h} from the tree
 * e007ac3 [1704] Add targets to create log_test_messages.{h,cc} from .mes
 * fcb6345 [1704] Throw if NULL is passed to logger.setInterprocessSync()
 * cd37331 [1704] Use @abs_top_builddir@ directly in the .py.in file
 instead of using an env variable
 * 277be10 [1704] Assert that the lockfiles exist
 * 8eb4eb3 [1704] Assert that the lockfile_test directory exists, and is
 removed
 * e72bc12 [1704] Move test directory creation to setUp() / tearDown()
 * 075eef9 [1704] style matters: don't omit {}, func name convention, typo.
 * 2e95197 [1704] Test remove_lock_files()
 * 7c1277b [1704] Use B10_FROM_BUILD instead of B10_FROM_SOURCE (contd.)
 * 994827b [1704] Use B10_FROM_BUILD instead of B10_FROM_SOURCE
 * 39ebe9d [1704] Don't set B10_FROM_SOURCE for logger unittest
 * 9227b2d [1704] Add documentation for InterprocessSync and
 InterprocessSyncFile
 * 1d5bd47 [1704] Add documentation for setInterprocessSync()
 * 328f878 [1704] In case NULL is passed as the sync object, do nothing and
 return
 * 16fc370 [1704] Move code to different places (no functional changes)
 * d575fba [1704] Add a comment about use of select() in the test
 * bd5494f [1704] Initialize sync_ in the initialization list
 * 8b555fc [1704] Update comment about using locking in the logger
 * 93fb5ca [1704] Remove obsolete include
 * caa5bb9 [1704] Make InterprocessSyncFile's destructor virtual
 * 227d017 [1704] style matters: long line, () for return, const, {
 position.
 * 30198a3 [1704] Use top_builddir during tests as top_srcdir may not be
 writable
 * c0a328b [1704] Unit test the logger for the lock
 * b45a54e [1704] Open lock files lazily
 * 8c455b3 [1704] Add a select() to the parent reader in case the child
 messes up
 * 31b153d [1704] Replace TEST_F with TEST
 * 10b434b [1704] Minimize code
 * db2fa0c [1704] fd_ cannot be -1 here
 * 09e8c9e [1704] Use a helper for lock/unlock/tryLock as they use the same
 pattern
 * 2bf7dad [1704] Remove separate class hierarchy for
 InterprocessSyncLocker
 * 876dd74 [1704] editorial nits: folded long lines, position of '*',
 sizeof(), constify.
 * 17f327d [1704] Add proper testcases for the file based locker
 * 9639134 [1704] Delete lock files when BIND 10 shuts down
 * 9427bd4 [1704] Update test environments to set B10_FROM_SOURCE
 * 588bffd [1704] Add InterprocessSync interface and a file based
 implementation
 * 106ec83 [1704] Use LoggerImpl as a testcase for InterprocessSync
 }}}

 Resolving as fixed. Thank you for the reviews Jinmei! :)

-- 
Ticket URL: <http://149.20.48.40/ticket/1704#comment:69>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development