BIND 10 #1771: database datasource incorrectly rejects "on zonecut" glue
BIND 10 Development
do-not-reply at isc.org
Sun Jun 3 23:50:12 UTC 2012
#1771: database datasource incorrectly rejects "on zonecut" glue
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
jinmei | Status: reviewing
Type: | Milestone:
defect | Sprint-20120612
Priority: | Resolution:
medium | Sensitive: 0
Component: data | Sub-Project: DNS
source | Estimated Difficulty: 3
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by muks):
Hi vorner
Replying to [comment:9 vorner]:
> I think this should work. However, I'd appreciate two things:
> * Test that the glue can be extracted by calling find.
This bug (tests which were broken) doesn't use FIND_GLUE_OK though.
> * An explanation comment about the `may_have_glue` variable. The name
is not crystal-clear and I think, while the purpose is obvious in the
context of this single diff, it would take some time to grasp the purpose
when reading the function.
I have added an example of what it indicates as a comment.
> Also, this allows the domain name to contain any A/AAAA, not just the
glue one. I'm not sure there's a reasonable way to check the A/AAAA is
really glue, though. So maybe comment the check may have a false negative
in that regard?
I didn't follow what you mean here by any A/AAAA. Can you give me an
example of what case you mean?
>
> And, as this is a publicly-observable bug, I think it should have a
changelog entry.
How about this:
{{{
XYZ. [bug] muks
The database datasource has been fixed to not reject glue records.
}}}
--
Ticket URL: <http://149.20.48.40/ticket/1771#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list