BIND 10 #2004: Message_makeResponse (libdns++ python wrapper) should catch exceptions
BIND 10 Development
do-not-reply at isc.org
Mon Jun 4 12:55:51 UTC 2012
#2004: Message_makeResponse (libdns++ python wrapper) should catch exceptions
-------------------------------------+-------------------------------------
Reporter: | Owner: muks
jinmei | Status: reviewing
Type: | Milestone:
defect | Sprint-20120612
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: DNS
libdns++ | Estimated Difficulty: 4
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: UnAssigned => muks
Comment:
I must confess I have not checked whether we also need to catch some more
specific exceptions that we know can be raised, but in general this code
looks fine.
I do have one suggestion, and that is before we do catch(...), we also
catch std::exception by name first, so we can at least print *something*
more than 'unknown exception' which is nice to prevent abort, but not
useful at all :)
--
Ticket URL: <http://bind10.isc.org/ticket/2004#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list