BIND 10 #2004: Message_makeResponse (libdns++ python wrapper) should catch exceptions

[BIND 10 Development]

#2004: Message_makeResponse (libdns++ python wrapper) should catch exceptions
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120612
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  libdns++                           |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jelte


Comment:

 Replying to [comment:7 jelte]:
 > I do have one suggestion, and that is before we do catch(...), we also
 catch std::exception by name first, so we can at least print *something*
 more than 'unknown exception' which is nice to prevent abort, but not
 useful at all :)

 Good point. :) Fixed.

 Replying to [comment:8 jelte]:
 > oh and for the exception we do define ourselves, we should probably have
 unit tests :) (like the InvalidMessageOperation)

 I have added tests for the non-generic catch()s that we've added (please
 check). A more thorough set of testcases for every exception thrown by
 Message would be best done in a new bug. The Message class is not fully
 covered by tests too.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2004#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development