BIND 10 #1955: Implement perfdhcp IPv4 packet handling
BIND 10 Development
do-not-reply at isc.org
Tue Jun 5 19:32:59 UTC 2012
#1955: Implement perfdhcp IPv4 packet handling
-------------------------------------+-------------------------------------
Reporter: | Owner: UnAssigned
stephen | Status: reviewing
Type: | Milestone: DHCP-
enhancement | Sprint-20120611
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: DHCP
perfdhcp | Estimated Difficulty: 32
Keywords: | Total Hours: 20
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 20 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by marcin):
* hours: 0 => 20
* estimatedhours: 0 => 32
* status: accepted => reviewing
* owner: marcin => UnAssigned
* totalhours: 0 => 20
Comment:
I added new class derived from dhcp::Pkt4 and corresponding unit tests.
Since, both PerfPkt6 and PerfPkt4 have common logic, as a part of this
ticket I moved the common logic to new class PktTransform. This class
exposes static functions that can be used to operate on raw DHCP message
buffers - needed for implementation of template files.
The 1956 is still in review and has not been checked in to master yet.
Since 1956 and 1955 share a lot of code I branched-off trac1955 from
trac1956. Finally, after PktTransform had been implemented I modified v6
packet handler to use it and removed redundant code. This change was
checked in to trac1955. For this reason the trac1955 is the branch that
has the latest changes for 1956 and 1955 so it makes sense to do code
review on trac1955 for both tickets.
Please review.
--
Ticket URL: <http://bind10.isc.org/ticket/1955#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list