BIND 10 #2016: search and remove scheduled changes in diff.py

[BIND 10 Development]

#2016: search and remove scheduled changes in diff.py
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120612
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Right, ok, er, right.

 it turns out that it was easier (in terms of implementation, code, and
 code on the calling side), to take a slightly different approach, and add
 find_updated() and find_all_updated(); which, for basic results, return
 the result of find() and find_all(), but taking the updates into account.

 The original approach would have needed several ways to search through the
 buffers, and update them. This is still kind of done now, but it's kept
 local to the Diff class.

 So major changes here:
 - if you delete an rr that you just added, it is not 'deleted' as such, it
 is removed from the additions (and vice versa)
 - added find_updated and find_all_updated. Which for basic success and
 notfound results modify the rcode and data as applicable
 - for cases where processing depends on existing data, session now uses
 these new find_updated calls.
 - re-enabled ns-rrset-deletion test, and added a few more

-- 
Ticket URL: <http://bind10.isc.org/ticket/2016#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development