BIND 10 #1514: Update SERIAL in DDNS

[BIND 10 Development]

#1514: Update SERIAL in DDNS
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  haikuo
                       Type:  task   |                Status:  reviewing
                   Priority:         |             Milestone:
  medium                             |  Sprint-20120612
                  Component:  DDNS   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:  DDNS   |  Estimated Difficulty:  4
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => haikuo


Comment:

 That looks almost ready, I have one final suggestion;

 if the result of find() on line 731 is not ZoneFinder.SUCCESS, there will
 be an exception, this is not a really big problem (it will be caught, and
 a SERVFAIL will be returned), but it is probably nicer for the
 administrator to check it here, and log an error.

 So I suggest to add the code
 {{{
 # We may implement recovering from missing SOA data at some point, but for
 now servfail on such a broken state
 if result != ZoneFinder.SUCCESS:
     raise UpdateError("Error finding SOA record in datasource.",
 self.__zname, self.__zclass, Rcode.SERVFAIL())
 }}}
 right below the find there (this exception should cause a nicer error to
 be logged)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1514#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development