BIND 10 #2003: support DDNS/TCP response

[BIND 10 Development]

#2003: support DDNS/TCP response
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  low    |  Sprint-20120612
                  Component:  DDNS   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:  DDNS   |  Estimated Difficulty:  5
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Replying to [comment:4 jinmei]:
 > I believe the intent of the former is clear from its documentation.
 > I've made this as a separate module so it can be eventually used
 > for revised versions of xfrin/xfrout, too.

 I thought we would use blocking reads/writes in xfrin/out (such as
 socket.sendall). I thought this is the reason why we wanted separate
 forked processes for them. Not that it would be a problem for the class,
 but I think it would be an overkill for such purpose.

 I think you forgot to put the dns_tcp_test.py to git. I hope you still
 have it somewhere. This is what I get (both check and distcheck) and I
 don't think I saw the test in the diff:
 {{{
 make[6]: Leaving directory
 `/home/vorner/work/bind10/src/lib/python/isc/server_common/tests'
 make[6]: *** No rule to make target `dns_tcp_test.py', needed by
 `distdir'.  Stop.
 make[5]: Leaving directory
 `/home/vorner/work/bind10/src/lib/python/isc/server_common'
 }}}

 Is dropping the connection silently on the quota the best thing to do?
 And, generally speaking, isn't 10 as the quota really low?

 Should the `PYSERVER_COMMON_DNS_TCP_SEND_ERROR` be logged as an ERROR
 instead of WARN? AFAIK WARN is for things that are possibly correct but
 might be wrong, while I don't see a way this could be correct in any
 situation.

 The two of the new log messages include the amount of data sent so far.
 Should it log how much it is total as well? (like „%2 of %3 bytes sent so
 far“)?

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/2003#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development