BIND 10 #1955: Implement perfdhcp IPv4 packet handling

BIND 10 Development do-not-reply at isc.org
Mon Jun 11 12:07:25 UTC 2012


#1955: Implement perfdhcp IPv4 packet handling
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:  DHCP-
  enhancement                        |  Sprint-20120611
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DHCP
  perfdhcp                           |  Estimated Difficulty:  32
                   Keywords:         |           Total Hours:  26
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  6      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  20 => 6
 * owner:  marcin => stephen
 * totalhours:  20 => 26


Comment:

 I implemented changes suggested in the review.

 '''Protected Variables'''
 We already had functions like getTransidOffset and getTransid, so I now
 use them in the code. I added setTransid public function as it indeed make
 sense to have something like this anyway.  The other protected members I
 left as they were (they are still protected and no extra getters/setters
 are added). Instead I added comments in PktN classes that they are
 referenced directly by perfdhcp classes.

 '''tests/tools/perfdhcp/pkt_transform.cc'''
 The input buffer is a std::vector<uint8_t>, not the InputBuffer. In this
 case there is no way to use setPosition() or equivalent.

 Please review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1955#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list