BIND 10 #1828: Python tests print warnings about unclosed file handles / sockets

[BIND 10 Development]

#1828: Python tests print warnings about unclosed file handles / sockets
-------------------------------------+-------------------------------------
                   Reporter:  muks   |                 Owner:  muks
                       Type:         |                Status:  closed
  defect                             |             Milestone:
                   Priority:         |  Sprint-20120619
  medium                             |            Resolution:  fixed
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Merged to master in commit 464682a2180c672f1ed12d8a56fd0a5ab3eb96ed:
 {{{
 * e295b40 [1828] Make code safer in case socket.socket() raises an
 exception
 * c37cc2d [1828] Rename variable to better match its use
 * c4b20d7 [1828] Add comments about the close() calls
 * 6ad0070 [1828] a couple of suggested clarification comments
 * 1fff16e [1828] style fix: folded a long line.
 * 74b4b2f [1828] Cleanup code by using with (for accept_sock)
 * ff9dd7d [1828] Make code safer by using with (for sock)
 * 8e741d8 [1828] Close the listen_sock in tearDown()
 * 7d741f7 [1828] Cleanup code by using with
 * d295c9e [1828] Close sockets created by socketpair when done
 * 74dbc76 [1828] Don't redirect stderr in tests
 * 9040c49 [1828] Cleanup code by using with
 * bbeee53 [1828] Don't redirect stdout in some tests
 * 86b4a93 [1828] Make code safer by using with
 * 5744904 [1828] Make code safer by using with
 * d96e91d [1828] Close MsgQ socket in except block
 * 3dd46b7 [1828] Cleanup listen socket in DDNSServer.shutdown_cleanup()
 * 1ece2ea [1828] Make code safer by using with
 * 933d2b6 [1828] Use with statement to auto-close file handles when done
 using them
 * aef9cc2 [1828] Close open handles when done using them (contd.)
 * 6725498 [1828] Close open handles when done using them (contd.)
 * 542d531 [1828] Close open handles when done using them (contd.)
 * fdb3dfb [1828] Close open handles when done using them (contd.)
 * eae421b [1828] Close open handles when done using them (contd.)
 * a9d5033 [1828] Close open handles when done
 }}}

 Resolving as fixed. Thank you for the reviews Jinmei.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1828#comment:28>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development