BIND 10 #1771: database datasource incorrectly rejects "on zonecut" glue

[BIND 10 Development]

#1771: database datasource incorrectly rejects "on zonecut" glue
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120703
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  3
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => jinmei


Comment:

 This branch is fine. I agree the code is cleaner now, but should we add a
 ChangeLog entry for it because the new branch allows non-glue records now?
 Even with `GLUE_OK`, this isn't strictly glue for any of the accepted
 meanings:
 {{{
      {"brokenns2.example.org.", "NS", "3600", "", "ns.example.com."},
      {"brokenns2.example.org.", "A", "3600", "", "192.0.2.1"},
 }}}

 Minor change: you may want to move the `is_origin` assignment into the `if
 (found.first)` block:

 {{{
 // @@ DatabaseClient::Finder::findInternal(const Name& name, const RRType&
 type,

      const bool is_origin = (name == getOrigin());
      final_types.insert(type);
      const FoundRRsets found = getRRsets(name.toText(), final_types,
 -                                        !is_origin, NULL,
 -                                        type == RRType::ANY());
 +                                        NULL, type == RRType::ANY());
      FindDNSSECContext dnssec_ctx(*this, options);
      if (found.first) {
          // Something found at the domain name.  Look into it further to
 get
 }}}

 Please also repeat for `not_origin` in a previous hunk too. No need to get
 these reviewed. :)
 You can go ahead and merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1771#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development